Do not access uninitialized part of adiabatic conditions #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think it is appropriate to just return a wrong result in this case? Maybe throwing in error would be safer (not that I understand when precisely this can happen). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago we removed all
adiabatic_conditions.is_initialized()statement, because the profile is now available for every position, except the (lower) uninitialized part. However, in some places plugins access this part before it is computed, see the attached case. Currently, there is no plugin that will cause this (because the adiabatic conditions do not access the initial conditions), but I am currently working on a plugin that will do this. Reinsert the check.