Be more conservative with regexes. #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, we only want to do one replacement (so don't use 'g') and only want to do it at the end of the filename (use the dollar sign for end of string).
bangerth
force-pushed
the
conservative-regex
branch
from
6d1532e
to
7a21d89
Compare
|
Looks good. I am not sure what happened with the aspect-8.5-gcc tester, but it seems to work for other pull requests (e.g. #1763), and this is unrelated to tests anyway, so I am going to merge. |
|
Internet of that machine was down for a few days. Sigh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, we only want to do one replacement (so don't use 'g') and
only want to do it at the end of the filename (use the dollar sign for end
of string).
This is an update to #1759. I'd appreciate if @gassmoeller could verify
that using the dollar sign in the regex with sed actually works as
expected. But it seems to work for me.