Ensure that the base class also gets to serialize its data. #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
force-pushed
the
fix-serialization
branch
from
cbe12bf
to
cc9b666
Compare
The current implementation of the various serialization functions of particle output classes have a comment that says that we ought to call the serialization function of the base class -- but then they all do not actually do so. Fix this. It doesn't current make any difference since the base class has nothing to serialize. But it may acquire some data at some point in the future, and this patch prevents the bug that would then become apparent.
bangerth
force-pushed
the
fix-serialization
branch
from
cc9b666
to
a114880
Compare
|
Makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the various serialization functions of particle output
classes have a comment that says that we ought to call the serialization function
of the base class -- but then they all do not actually do so. Fix this.
It doesn't current make any difference since the base class has nothing to serialize.
But it may acquire some data at some point in the future, and this patch prevents
the bug that would then become apparent.