Update outdated material model interface description #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
reviewed
Jul 7, 2017
doc/manual/manual.tex
Outdated
| instead of the evaluate() function discussed above. They are now a deprecated | ||
| way of implementing a material model. You can get your old model working | ||
| by deriving from InterfaceCompatibility instead of Interface. | ||
| instead of the evaluate() function discussed above. This old interface is not longer |
doc/manual/manual.tex
Outdated
| way of implementing a material model. You can get your old model working | ||
| by deriving from InterfaceCompatibility instead of Interface. | ||
| instead of the evaluate() function discussed above. This old interface is not longer | ||
| supported, and you need to restructure your plugin to implement evaluate() |
There was a problem hiding this comment.
just drop ", and you need to ...". This sentence is only true for a short period of time (because everyone will have updated it quickly) and it's not worth keeping in perpetuity.
doc/manual/manual.tex
Outdated
| @@ -10316,9 +10302,9 @@ \subsubsection{Material models} | |||
| starting point for implementations of new material models. | |||
|
|
|||
| Older versions of \aspect{} used to have individual functions like viscosity() | |||
| instead of the evaluate() function discussed above. They are now a deprecated | |||
There was a problem hiding this comment.
While you're there, can you also mark up "viscosity()" and "evaluate()" as code?
gassmoeller
force-pushed
the
remove_seismic_velocities_interface_manual
branch
from
43a450a
to
0cbe91b
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found these outdated descriptions during reading a section of the manual.