Advertise CONTRIBUTING.md #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
reviewed
Jul 7, 2017
CONTRIBUTING.md
Outdated
| @@ -9,7 +9,9 @@ If you are new to using git or the GitHub platform you may find it | |||
| helpful to review [video lecture | |||
| 32.8](http://www.math.tamu.edu/~bangerth/videos.676.32.8.html), which | |||
There was a problem hiding this comment.
uh, that's outdated. can you update that as well while there? (tamu->colostate is all you need)
doc/manual/manual.tex
Outdated
|
|
||
| Let us assume you found something in \aspect{} to improve, something you did not | ||
| understand, or something that is simply wrong. Do something about it! No matter | ||
| if you are a C++-expert or first-time user, there are no such things as too-unimportant |
There was a problem hiding this comment.
if you are a C++-expert -> whether you are a C++ expert
gassmoeller
force-pushed
the
update_contributing_instructions
branch
from
a961c24
to
d785e4e
Compare
|
I guess, when one is a C++-expert, one is technically a C+ expert, and whether one is such an expert or not depends on the project 😄. Did the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hopefully closes #438. Instead of duplicating this information we should explain it once in CONTRIBUTING.md (or in places linked from there) to avoid getting the manual and the file out of sync.