Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and apply update source script #1852

Merged
merged 1 commit into from
Jul 13, 2017

Conversation

gassmoeller
Copy link
Member

The current source update script renames prescribed_traction_boundary_indicators into prescribed_boundary_traction_indicators, which is inconsistent with our writing of prescribed_velocity_boundary_indicators. Fix that by excluding those cases from the replacement. Not sure why I did not notice this earlier.
Also there is one occurrence of tracers that was not properly replaced, because it was an open pull request at the time I applied the script to the repository.

@tjhei
Copy link
Member

tjhei commented Jul 13, 2017

Looks good. Have you tried applying the scripts to the .ccs in tests/ benchmarks/ and cookbooks/ to make sure it doesn't change anything?

@gassmoeller
Copy link
Member Author

Yes, I applied the script to all .cc and .h files in the main repo and the one particle change was the only generated diff.

@tjhei tjhei merged commit 47ea262 into geodynamics:master Jul 13, 2017
@gassmoeller gassmoeller deleted the fix_regexp_traction branch July 13, 2017 17:37
@tjhei
Copy link
Member

tjhei commented Jul 13, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants