Fixed bug preventing particles from working in Solcx benchmark #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-tests |
|
There is one failing test. Does anyone have an idea what the reason is? |
|
Yes, this test was broken on master (fixed in #1881 earlier today). Since this PR is completely unrelated to the broken test I am in favour of just merging it. A rebase would simply be unnecessary work here. |
|
I agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The density and viscosity values at each point were not being set to the values on their respective compositional fields in solcx_compositional_fields.h. This is because SolCxCompostionalMaterial was outdated and needed to be updated. As a result, we would always obtain the convergence results for the direct method regardless of the method being used in the Solcx parameter file.
Currently, if a compositional field carries viscosity, then the convergence results are less accurate then that of the direct methods. However, the convergence results for Solcx are exactly the same as the direct method if only density is carried on a compositional field.