Move morency doin material model to cookbook #2005
Conversation
|
Hm, the As for the actual content of the patch, could someone with more knowledge of the material models take a look? |
gassmoeller
force-pushed
the
move_morency_doin
branch
from
bb61718
to
ccffe72
Compare
|
Yes, the test now has a line about loading the shared library. I think @jperryhouts was the only one working with this material model. Jonathan, could you have a look at this? It is really just moving two files and some lines around (and shortening the manual somewhat). |
|
I am all for this! I implemented this to reproduce a paper once, and haven't found it useful since. I even suggested removing it all together a while ago. Also, does anyone know of a way to get more obvious notifications of @ mentions? As it is I'm 'watching' this repository so I get emails about all these comments anyway. Who knows how many threads I've accidentally ignored because of that! |
|
@jperryhouts |
| @@ -0,0 +1,39 @@ | |||
| # Copyright (C) 2011 - 2016 by the authors of the ASPECT code. | |||
| @@ -23,5 +23,5 @@ set xlabel "Viscosity (Pa s)" | |||
| set logscale x | |||
| set xrange [1e18:1e28] | |||
| set xtics 1e18,100,1e30 | |||
| plot "< grep -v -e \"^$\" -e \" 0 $\" output/depth_average.gnuplot" using 11:(-$1/1000) with lines | |||
| plot "< grep -v -e \"^$\" -e \" 0 $\" output/depth_average.gnuplot" using 14:(-$1/1000) with lines | |||
There was a problem hiding this comment.
Why did this line change? I guess you checked that it produces the correct figure with this version?
gassmoeller
force-pushed
the
move_morency_doin
branch
from
ccffe72
to
f73ce64
Compare
|
I fixed the copyright years. The different column is a consequence of our changes to the statistics file over time (likely the addition of the time step length, possibly the nonlinear iteration count, and or Stokes inner iterations). I checked that the figure now produces the same result as is included in the manual. |
|
@jdannberg Thanks! That's super helpful. It looks like there's also an undocumented header, |
Something I wanted to do for a long time. Move the Morency & Doin material model into a separate folder in the cookbooks, and remove it from the other material models. Also shorten the manual section by removing unnecessary parameters.