Fix serialization with deal.II 8.5 and no particle output #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix #2019 |
|
Looks good. Can you please fix the test output? |
gassmoeller
force-pushed
the
fix_particle_serialization_without_output
branch
from
7f68c8d
to
08ecd53
Compare
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that emerged during a discussion with @egpuckett on the mailing list. The serialization of the output plugin of the particle world tried to dereference an uninitialized unique pointer if no plugin was selected. Now we simply ignore the null pointer (it is not used anyway, and in the load function it is not initialized either).
This is not an issue for deal.II 9.0.pre, because we no longer use the plugin in that case. The new test ensures this behavior is tested.