enable free surface for all solver schemes #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdannberg
force-pushed
the
enable_free_surface_for_all_solver_schemes
branch
from
63a6f27
to
052543d
Compare
|
This makes sense for our current implementation of the free surface (which is outside of the nonlinear iteration). One thing that we need to keep in mind is that the nonlinear solver will not iterate over the free surface, but will only find the correct velocities for the given topography, and topography will only be updated for the next timestep. This is something we can improve at some (undetermined) point in the future. Ready to merge if the tester passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago, @gassmoeller restructured the solvers schemes (see #1850) so that the free surface computation is done outside of these schemes. This means that that there is no reason any more why any of the solver schemes should not work with free surface, the two things are now independent of each other. This pull request removes the Assert that was still there to prevent those things being used together.
I also added a test for the iterated IMPES solver and made sure that the result is similar to the test that used iterated Stokes (the first 2-3 digits of RMS velocity and topography are the same).