Clean up and document Newton Stokes preconditioner. #2116
Conversation
There was a problem hiding this comment.
Looks good, just one comment about the approximation of J^{uu} when using the defect correction Picard. Personally, I doubt if saying that we approximate J^{uu} in the case of defect correction Picard is the correct way of saying it, since in this case we are specifically not interested in J^{uu}, but we can discuss that later.
| + one_over_eta * this->get_pressure_scaling() * this->get_pressure_scaling() | ||
| * (scratch.phi_p[i] * scratch.phi_p[j])) | ||
| data.local_matrix(i, j) += ( | ||
| // top left block: approximate J^{uu} |
There was a problem hiding this comment.
It might be good the make the distinction between this 'approximation' and the approximation of J^{uu} for the full Newton method. Something like: 'top left block: approximate J^{uu} by A^{uu} when using the defect correction Picard.'
There was a problem hiding this comment.
Well, it's not A^uu. The A^uu block uses the symmetric gradient, but this block here uses the regular gradient.
There was a problem hiding this comment.
You are right, so we are basically approximating A^uu
|
@MFraters -- updated version now online |
| // top left block: for the current case with | ||
| // derivative_scaling_factor==0 the top left block | ||
| // of the system matrix only contains the usual | ||
| // Stokes term. so approximate this block in the |
There was a problem hiding this comment.
Sure. Though we have many comments that start sentences with lower-case letters. For example, the first line of this comment starts with a lower-case letter.
But happy to change -- new version now online.
There was a problem hiding this comment.
ah, I didn't notice that, I now see it everywhere... Anyway, not a big issue for me. Will merge it when the testers are done :)
No description provided.