Optimize seismic ic #2127
Merged
Optimize seismic ic #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm in the field until Tuesday but am happy to review this as soon as I'm back. |
|
Ah, nice job -- all it took was hoisting some constants out of a loop :-) |
|
Nice speed-up insight @gassmoeller, it looks fine to me. I may need to also update ASPECT on our cluster:) |
|
Ok, great. @jaustermann it would be great if you could take a look when you are back and have some time. I would like to merge this end of the week / first half of next week to make sure it makes it into the release. |
|
I went through all the changes and they look good to me. The S40 and Savani tests are also good checks that the content hasn't changed. Awesome speedup, thanks Rene! I can merge this if it's okay - maybe my first merge?! |
|
Sure, go ahead 馃槃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally fix #962. Something I wanted to do for a long time (waiting time at an airport is so useful 馃槃). Both plugins show a ~15X speedup with the changes in the first commit. They are still a big part of an instantaneous model (~50% for the tests, compared to 90% before), but at least they are now comparable to a Stokes solve, which should be good enough. The second commit adjusts the code style to our usual convention and uses more correct types for many indices.
@jaustermann or @Shangxin-Liu maybe one of you could take look and do a review of this PR, since you wrote the initial code? Did I mess anything up?