Fix visco_plastic and diffusion_dislocation thermal diffusivity #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice. Please update the test results and add a changelog entry in the style of 'Fixed: The material models ... now correctly use the reference density for ... if the formulation ... is used'. |
naliboff
force-pushed
the
fix_thermal_diffusivity
branch
from
43b9e8b
to
24da407
Compare
|
@gassmoeller - I added a changelog entry and fixed the test. Thanks for going through this and let me know if there is anything else you would like addressed. |
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2170. It turns out none of the
diffusion_dislocationorvisco_plastictests use thereference density profileformulation for the temperature equation (I have no idea why I assumed they did .. careless error).As previously written, the two material models did not check whether adiabatic conditions are initialized before asking for the density from
adiabatic_conditions. This is now fixed and I've added tests that usereference density profilein both material models. I also checked that the other changes (basic statistics&thermal diffusivitypost processors) in #2170 work withreference density profile, but did not add any associated tests.