Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new cite.html #2195

Merged
merged 3 commits into from May 1, 2018
Merged

add new cite.html #2195

merged 3 commits into from May 1, 2018

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented May 1, 2018

No description provided.

@tjhei
Copy link
Member Author

tjhei commented May 1, 2018

As discussed during the meeting today. I will follow up with PRs for linking to it in readme/manual/etc.

Copy link
Contributor

@jdannberg jdannberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good except for the few small changes. Feel free to merge yourself once you've addressed them.

cite.html Outdated
</p>

<p><b>3. Citation</b><br>
Please cite one of all of the following documents. The canonical reference for this software:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one or all

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And can you put the sentence "The canonical reference for this software" into a new line?

index.html Outdated
@@ -111,6 +111,18 @@ <h2>
</td>
</tr>

<tr>
<td style="vertical-align:top;height:4em">
<a class="btn btn-success" href="cite.html">Cite! &raquo;</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other green boxes all have a different size. I think that's because they have the style="width:100%" code? Can you fix that?

@tjhei
Copy link
Member Author

tjhei commented May 1, 2018

fixed. I am merging so we can take a look at it...

@tjhei tjhei merged commit eaa79e4 into geodynamics:www May 1, 2018
@tjhei tjhei deleted the www-cite-thing branch May 1, 2018 19:28
@jdannberg
Copy link
Contributor

I think it looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants