Add bib entry for dynamic core reference Nimmo 2004 #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-tests |
bangerth
approved these changes
Jun 19, 2018
gassmoeller
reviewed
Jun 19, 2018
| @@ -160,16 +160,16 @@ namespace aspect | |||
| { | |||
| prm.declare_entry ("Tm0","1695", | |||
| Patterns::Double (0), | |||
| "Melting curve (Nimmo et al. [2004] eq. (40)) parameter Tm0. Units: $K$."); | |||
| "Melting curve (\cite{NPB+04} eq. (40)) parameter Tm0. Units: $K$."); | |||
There was a problem hiding this comment.
You used the double backslash \\cite for the description above, but not in this case and the three occurences below. Please add it in those places as well. Just to explain: Everything in the double quotation marks is parsed through the deal.II parameter handler, and thus needs an extra escape character. That is why it is fine to write \cite in the documentation of the header file, but you need to write \\cite for every parameter description in the .cc file.
jonpkay
force-pushed
the
Bibentry_dynamic_core
branch
from
0ba9524
to
dd619b4
Compare
bangerth
requested changes
Jun 19, 2018
There was a problem hiding this comment.
@gassmoeller had requested changes, so I'll block for a moment. Talk to me if you need help!
jonpkay
force-pushed
the
Bibentry_dynamic_core
branch
from
dd619b4
to
ba1adcd
Compare
bangerth
approved these changes
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2238