Use interface volume fraction function in the visco elastic material model #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anne-glerum
changed the title
|
👍 Looks good. I just did the same thing in the proto vep model (https://github.com/naliboff/aspect/tree/vep). I ran the same viscoelastic tests with the model and the tests results changed very slightly (last few digits, etc). I'm not sure if this is due to the volume fractions calculation or something else, but we'll see if the tests still pass. |
|
@naliboff hmm all tests pass here |
|
@anne-glerum - Must have been some other small change in the vep model. Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Item 1 of #2266