Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit_tests: convert tests/additional_output.prm #2427

Merged

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented Jun 25, 2018

No description provided.

@tjhei
Copy link
Member Author

tjhei commented Jun 25, 2018

oops, broke 2 tests. Will get back to this...

@bangerth
Copy link
Contributor

I guess we have a whole bunch of these kinds of tests. Is that worth anyone's time to convert them?

@tjhei
Copy link
Member Author

tjhei commented Jun 25, 2018

I guess we have a whole bunch of these kinds of tests. Is that worth anyone's time to convert them?

We have 11 of those. This is not too much work and will serve as an example for future unit tests, I think. It is also a way to learn how to write tests like this.

@tjhei tjhei force-pushed the unit_tests-move-additional-output branch from 94ee823 to 44795c1 Compare June 25, 2018 19:02
@tjhei
Copy link
Member Author

tjhei commented Jun 25, 2018

this is ready!

@gassmoeller
Copy link
Member

This is correct!

@gassmoeller gassmoeller merged commit b65cd40 into geodynamics:master Jun 25, 2018
@tjhei tjhei deleted the unit_tests-move-additional-output branch June 25, 2018 22:37
freddrichards pushed a commit to freddrichards/aspect that referenced this pull request May 20, 2019
…onal-output

unit_tests: convert tests/additional_output.prm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants