added clarification to simple compressible model #2468
Conversation
| * and isothermal compressibility. The density decays linearly with the | ||
| * temperature and increases exponentially with pressure. | ||
|
|
||
| * Note that this material model is not strictly self-consistent; |
There was a problem hiding this comment.
Add the asterisk also for the empty line.
|
|
||
| * Note that this material model is not strictly self-consistent; | ||
| * the partial derivative of the density with respect to temperature | ||
| * at constant pressure is only equal to -alpha rho along the |
There was a problem hiding this comment.
can you use dollar-enclosed formulas here and below?
bobmyhill
force-pushed
the
improve_compressible_doc
branch
3 times, most recently
from
f3ca488
to
1c7e1eb
Compare
|
Thanks @bangerth. I discussed this with @gassmoeller and @jdannberg, and I think we're on the same page. I added similar text to both the .cc and .h; is there any other file I need to add the text to? |
| "Note that this material model is not strictly self-consistent; " | ||
| "$\\partial \\rho / \\partial T |_P = -\\alpha \\rho$ only along the " | ||
| "reference isentrope, and " | ||
| "$\partial \rho / \partial P |_T = \beta \rho$ only if the isentrope " |
There was a problem hiding this comment.
Almost. You need to double up the backslashes here.
|
I'll let @gassmoeller make the call here. |
bobmyhill
force-pushed
the
improve_compressible_doc
branch
from
1c7e1eb
to
1945655
Compare
bobmyhill
force-pushed
the
improve_compressible_doc
branch
from
1945655
to
88a5423
Compare
|
I've rephrased the comments to be more pragmatic, and will add a couple of paragraphs to the ASPECT manual to describe how to make thermodynamically self-consistent material models. |
|
@gassmoeller, @jdannberg, is this better now? |
|
Let's go with this. You were also willing to write a section for the manual about these issues in general, right? If so, can you open a github issue that reminds us to do this? |
…le_doc added clarification to simple compressible model
A few lines to explain that the simple compressible model doesn't obey Maxwell's relations.