Update viscoplastic FEValues quadrature #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks reasonable to me, but I will let @jdannberg take a look. |
jdannberg
approved these changes
Jul 23, 2018
freddrichards
pushed a commit
to freddrichards/aspect
that referenced
this pull request
May 20, 2019
…es_quadrature Update viscoplastic FEValues quadrature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the
visco_plasticquadrature formula assumption inFEValues, which addresses #2579.@jdannberg - Let me know if this is not what you had in mind and thanks again for catching this!