Add test for the named additional output postprocessor #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassmoeller
force-pushed
the
add_test_multiple_named_outputs
branch
from
38c4fb6
to
73a20e7
Compare
tjhei
reviewed
Dec 1, 2018
| for (unsigned int i=0; i < in.position.size(); ++i) | ||
| { | ||
| const double y = in.position[i](1); | ||
| prescribed_field_out->prescribed_field_outputs[i][1] = std::exp(-y*y/2.0); |
There was a problem hiding this comment.
wouldn't it make sense to use a different expression here compared to below?
tjhei
approved these changes
Dec 1, 2018
gassmoeller
force-pushed
the
add_test_multiple_named_outputs
branch
from
73a20e7
to
2467a16
Compare
gassmoeller
force-pushed
the
add_test_multiple_named_outputs
branch
from
2467a16
to
14dcc5d
Compare
|
I addressed the comment, and all testers are happy. Since this was approved I am going to merge. |
|
Thanks for adding the testcase! |
freddrichards
pushed a commit
to freddrichards/aspect
that referenced
this pull request
May 20, 2019
…e_named_outputs Add test for the named additional output postprocessor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test for #2679.