Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify default melt threshold and cookbooks #2884

Conversation

gassmoeller
Copy link
Member

This PR is branched off from #2876 and includes the changes to the default melt scaling threshold I discussed with @tjhei and @jdannberg. It also includes the changes to the melt cookbooks that are necessary to run them smoothly after the change.

@gassmoeller gassmoeller force-pushed the modify_default_melt_threshold_and_cookbooks branch from 1ee2f0f to f0719b1 Compare April 11, 2019 19:34
Copy link
Contributor

@jdannberg jdannberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Ready to merge from my side once you fix the typo.

@@ -43,6 +49,9 @@ end
# of 5e-3/year), which should be substantially shorter than the time step size,
# so that the melt fraction will always be close to equilibrium.
# As the model includes melting and freezing, we do not have to extract any melt.
# We also slightly reduce the depence of shear viscosity on the melt fraction,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depence --> dependence

@gassmoeller
Copy link
Member Author

Ok, fixed.

@gassmoeller gassmoeller merged commit 3632a26 into geodynamics:master Apr 13, 2019
@gassmoeller gassmoeller deleted the modify_default_melt_threshold_and_cookbooks branch April 13, 2019 19:36
freddrichards pushed a commit to freddrichards/aspect that referenced this pull request May 20, 2019
…elt_threshold_and_cookbooks

Modify default melt threshold and cookbooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants