Multicomponent equation of state #3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdannberg
force-pushed
the
multicomponent_eos
branch
2 times, most recently
from
a2a6585
to
1cbf07f
Compare
jdannberg
force-pushed
the
multicomponent_eos
branch
from
1cbf07f
to
873090f
Compare
|
This is now rebased to the current master. |
bangerth
approved these changes
May 30, 2019
|
There are two failing tests: |
|
I updated the test results. The only difference was a change in iteration count. |
gassmoeller
approved these changes
May 30, 2019
|
|
||
| /** | ||
| * Read the parameters this class declares from the parameter file. | ||
| * The optional parameter @p n_compositions determines the maximum |
There was a problem hiding this comment.
There is no optional parameter here.
|
|
||
| /** | ||
| * Declare the parameters this class takes through input files. | ||
| * The optional parameter @p n_compositions determines the maximum |
There was a problem hiding this comment.
There is a different optional parameter here.
|
|
||
|
|
||
| private: | ||
| // Vector of reference densities $\rho_0$ with one entry per composition, |
There was a problem hiding this comment.
Make these comments into doxygen documentation: /** ... */. Same for all parameters below.
| has_background_field, | ||
| "Specific heats"); | ||
| } | ||
|
|
|
I addressed your comments. |
gassmoeller
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another pull request based on #3036 (so only the last commit is new).
It adds an equation of state for multicomponent models and uses it in 4 different material models. There is another material model where this could potentially be used, which is the diffusion_dislocation model. The difference here is that diffusion_dislocation only has one value for the specific heat (but a vector with entries for each composition for the densities and thermal expansivities). This may be worth changing.
What do you think?