unity: move some files to the end #3653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 3, 2020
bangerth
reviewed
Aug 3, 2020
CMakeLists.txt
Outdated
| LIST(INSERT TARGET_SRC 0 ${HELPER_PATH}) | ||
| # special treatment of some files for unity builds: | ||
| LIST(APPEND UNITY_LAST_FILES | ||
| "source/simulator/core.cc;source/volume_of_fluid/handler.cc") |
There was a problem hiding this comment.
so helper_functions.cc is no longer needed?
There was a problem hiding this comment.
helper_functions was moved to the front to be in front of core.cc, Now I move things to the back instead.
|
updated. |
bangerth
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix instantiation warnings/errors
part of #3633
fixes #3651
closes #3650 (better alternative)
related to #3637