CMake: clean up unity file handling #3730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
changed the title
tjhei
force-pushed
the
cmake_unity_cleanup
branch
from
8c24eb8
to
b5bf5a1
Compare
tjhei
changed the title
|
ready for review. |
MFraters
reviewed
Aug 7, 2020
| @@ -144,9 +144,23 @@ if(ASPECT_WITH_WORLD_BUILDER) | |||
| CONFIGURE_FILE("${WORLD_BUILDER_SOURCE_DIR}/source/config.cc.in" "${CMAKE_BINARY_DIR}/world_builder_config.cc" @ONLY) | |||
| LIST(INSERT TARGET_SRC 0 "${CMAKE_BINARY_DIR}/world_builder_config.cc") | |||
|
|
|||
| # Move some file to the end for unity builds to make sure other file come | |||
There was a problem hiding this comment.
Just as a clarification for me, this text is just to explain what happens, e.g. the code has not changed in functionality, or has it? As far as I can see you only moved the foreach code up, and accounted for that the source file contains the full name. Is that correct?
|
Looks good to me. I does need a rebuild, but I am not sure if I can do that ( /rebuild ) |
bangerth
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #3724