Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some helpful comments to GMG code #3780

Merged
merged 2 commits into from Aug 14, 2020

Conversation

tcclevenger
Copy link
Contributor

Adding some more explanatory comments to the stokes_matrix_free.h/.cc files. Let me know if anyone has other places that deserve some clarification.

Copy link
Contributor Author

@tcclevenger tcclevenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few questions for reviewers.

include/aspect/stokes_matrix_free.h Show resolved Hide resolved
include/aspect/stokes_matrix_free.h Show resolved Hide resolved
include/aspect/stokes_matrix_free.h Show resolved Hide resolved
Copy link
Member

@tjhei tjhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This is pretty good, only some minor comments.

source/simulator/stokes_matrix_free.cc Outdated Show resolved Hide resolved
include/aspect/stokes_matrix_free.h Show resolved Hide resolved
@bangerth bangerth merged commit 2b5446b into geodynamics:master Aug 14, 2020
@tcclevenger tcclevenger deleted the comment_gmg_code branch August 14, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants