Added compute_strain_rate_and_derivative to ConstantViscosityPrefactors, with unit test #3800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobmyhill
force-pushed
the
add_strain_rate_deriv_to_constant_viscosity
branch
from
14934dc
to
c865b8e
Compare
bobmyhill
force-pushed
the
add_strain_rate_deriv_to_constant_viscosity
branch
from
c865b8e
to
4d235e8
Compare
bobmyhill
changed the title
bobmyhill
changed the title
|
I thought about converting this to a true unit test in the unit test directory, but this way requires the same amount of code. The internal functions of the rheology modules are impossible to access without simulator_access. |
gassmoeller
reviewed
Aug 18, 2020
|
That was the original intention, but in coding up a generalisation of diff-disl yesterday, I realised that I didn't actually use the constant viscosity strain rate or derivatives directly. I jumped the gun a bit, sorry about that. So for now I think this PR can be closed. |
|
Thanks, no need to be sorry. Keep the branch around in case we need it in the future 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a compute_strain_rate_and_derivative function to the ConstantViscosityPrefactors rheology module.
It also adds a new test, rheology_checker.prm, that is essentially a unit tester for otherwise hard-to-reach functions within the rheology module. I intend to add to this test as I add compute_strain_rate_and_derivative to more rheology plugins.
This PR is a continuation of the quest started in #3759.