Do not create unnecessary failing assembler for compressible Newton models with full A block preconditioner #4465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassmoeller
changed the title
gassmoeller
force-pushed
the
avoid_creating_unnecessary_assembler
branch
from
43a9323
to
709ffe8
Compare
jdannberg
approved these changes
Jan 28, 2022
|
Changelog added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bug in debug mode I noticed in one of @elodie-kendall's models. If we set up a compressible model with a Newton solver and use the full A block of the Stokes matrix for the preconditioner, then the NewtonHandler still adds an assembler for the compressible terms in the preconditioner, although the preconditioner matrix is not used (the full matrix is used instead). Additionally the added assembler will throw an assertion. This change unifies the code paths between the Newton solver and the regular solver (which does not add the assembler for these models).