Explain to the compiler that there is an external instantiation of some member variables. #5188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
reviewed
Jul 7, 2023
| ASPECT_INSTANTIATE(INSTANTIATE) | ||
|
|
||
| // Now also instantiate static member variables: | ||
| template |
There was a problem hiding this comment.
Can you use the ASPECT_INSTANTIATE macro above? This would do the dim part for you.
…me member variables.
|
I needed to get far enough in my compile to actually compile this file locally. I think this should now work. |
|
OK, this seems to work now! |
gassmoeller
approved these changes
Jul 7, 2023
tjhei
approved these changes
Jul 8, 2023
bangerth
added a commit
that referenced
this pull request
Jul 8, 2023
[2.5] take over extern template #5188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #5175.