make assert throw consistent between geometry models for whether a po… #5197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int is in the domain
bangerth
approved these changes
Jul 7, 2023
gassmoeller
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a spherical shell with 90 degrees opening angle and with initial lithostatic pressure on the lateral boundaries, initially the error is "After displacement of the mesh, this function can no longer be used to determine whether a point lies in the domain or not.", from the point_is_in_domain function. Does message does not appear for a box and chunk geometry, and it should be able to assess whether this given point (for the initial lithostatic pressure), is in the domain or not because this assessment happens before any mesh/free surface deformation.
I now changed the AssertThrow in the spherical shell to the same conditions as in the box geometry, and also made the chunk assertthrow consistent with that of the box geometry. (also see issue #4715 )