improved parameter description for replace_placeholders function #5201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
requested changes
Jul 7, 2023
source/structured_data.cc
Outdated
| * boundary_name placeholder (%s). Do not only specify filenumber | ||
| * placeholder (%d). Placeholders order is first boundary_name | ||
| * (%s), then filenumber (%d). | ||
| */ |
There was a problem hiding this comment.
You're currently talking to @MFraters about indentation. This is a place that the indentation script would have automatically fixed for you:
Suggested change
| */ | |
| */ |
mfmweerdesteijn
force-pushed
the
parameter_description_function
branch
from
fa54d23
to
1dcc535
Compare
gassmoeller
approved these changes
Jul 8, 2023
|
/rebuild |
bangerth
approved these changes
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't clear that you cannot only specify the time step placeholder, even when there is only one boundary used. Very clear overview in the short Issue #4999 . I improved the replace_placeholders function description.