Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: run on branches #5210

Merged
merged 2 commits into from Jul 9, 2023
Merged

CI: run on branches #5210

merged 2 commits into from Jul 9, 2023

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented Jul 8, 2023

Run github actions also on branches (important for the releases)

@gassmoeller
Copy link
Member

This would trigger the actions on every users fork for every push they make. Can you somehow limit the trigger to geodynamics/aspect or to only the release branches?

@tjhei
Copy link
Member Author

tjhei commented Jul 8, 2023

This would trigger the actions on every users fork for every push they make.

That does not harm us or cost anything, I would think?

Anyways. I tried changing it to only test certain branches now. Not sure how we can test this...

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks correct and will save quite a bit of energy ;-).

@gassmoeller
Copy link
Member

It looks like the actions now dont trigger. Can you try pull_request: instead of pull_request?

@gassmoeller
Copy link
Member

Seems to work now.

@gassmoeller gassmoeller merged commit bc85185 into geodynamics:main Jul 9, 2023
6 checks passed
@tjhei tjhei deleted the actions-branches branch July 9, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants