[WIP] Update cig logo option for sphinx #5216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
approved these changes
Jul 8, 2023
|
Oh, this was still marked as [WIP] and I totally missed it. I guess that gives you a chance for follow-up PRs... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "extra_navbar" option has been removed in newer versions of the sphinx-book-theme and I get warnings about it when building the documentation on my system. Readthedocs seems to be fine for now, but if the new option works on readthedocs we may as well already update to avoid the warnings (which are treated as errors by our settings).
I marked this WIP because I first want to check how this PR looks like on readthedocs.