Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that material model supports elasticity when it is enabled #5218

Merged
merged 1 commit into from Jul 8, 2023

Conversation

anne-glerum
Copy link
Contributor

See #4985. When a material model does not support elasticity, but elasticity is enabled, Throw a helpful exception.

I left in the AssertThrow in elasticity.cc that checks that Enable elasticity is set to true (so it checks the reverse of the new AssertThrow).

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

Copy link
Contributor

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, nice!

@bangerth
Copy link
Contributor

bangerth commented Jul 8, 2023

Might want to squash the 5 commits into one :-)

@gassmoeller gassmoeller merged commit 1971dd6 into geodynamics:main Jul 8, 2023
6 checks passed
@anne-glerum anne-glerum deleted the use_Enable_elasticity branch July 8, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants