Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly set up two merged boxes for nonzero Y origin #5221

Merged
merged 2 commits into from Jul 9, 2023

Conversation

jdannberg
Copy link
Contributor

The computation of the upper box origin in the two merged boxes geometry model did not take into account a nonzero origin. This is fixed in this pull request. I also created a test case.

Below are images for a box with a lithosphere thickness of 80 km (the same model as in the new test).

Before:
wrong

After:
right

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you add a changelog entry for this change? It is an important enough fix to document.

@jdannberg
Copy link
Contributor Author

Thank you! I added a changelog entry.

@gassmoeller
Copy link
Member

/rebuild

@gassmoeller gassmoeller merged commit 037908e into geodynamics:main Jul 9, 2023
6 checks passed
@jdannberg jdannberg deleted the merged_boxes_origin branch July 9, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants