Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace viscoplastic parameter with Enable elasticity #5225

Merged

Conversation

anne-glerum
Copy link
Contributor

@anne-glerum anne-glerum commented Jul 9, 2023

Instead of an additional parameter in the viscoplastic material model, use the parameter Enable elasticity in subsection Formulation to determine whether elasticity should be switched on. Enable elasticity needs to be true in any case to use elasticity in the viscoplastic material model.

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

@anne-glerum anne-glerum changed the title Replace viscoplastic input prm with Enable elasticity Replace viscoplastic parameter with Enable elasticity Jul 9, 2023
Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but this will require changes to parameter files and should therefore also get a changelog entry.

source/material_model/rheology/visco_plastic.cc Outdated Show resolved Hide resolved
@anne-glerum anne-glerum force-pushed the replace_include_viscoelasticity branch from fbfa127 to 9aaa8a5 Compare July 9, 2023 18:47
Copy link
Contributor

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the old and new parameter had been in the same section, we could have declared them as aliases: https://dealii.org/developer/doxygen/deal.II/classParameterHandler.html#aecb847561585089c4c7fcf51eddece16 But this doesn't work with parameters in different sections.

@bangerth bangerth merged commit dbd7c1c into geodynamics:main Jul 9, 2023
6 checks passed
@anne-glerum
Copy link
Contributor Author

If the old and new parameter had been in the same section, we could have declared them as aliases: https://dealii.org/developer/doxygen/deal.II/classParameterHandler.html#aecb847561585089c4c7fcf51eddece16 But this doesn't work with parameters in different sections.

Good to know!

@anne-glerum anne-glerum deleted the replace_include_viscoelasticity branch July 9, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants