Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravity std::pow() update #5226

Merged
merged 2 commits into from Jul 9, 2023
Merged

Conversation

ryanstoner1
Copy link
Contributor

Resolves #4485.

Replaces pow(x,2) and pow(x,3) with multiplication for speedup. Tests from #4687 should apply.

Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.

Describe what you did in this PR and why you did it.

Before your first pull request:

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

Copy link
Contributor

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

For reference, when you write patches, you don't need to merge the main branch into your development branch. github will automatically make sure nothing gets lost.

@bangerth
Copy link
Contributor

bangerth commented Jul 9, 2023

/rebuild

@ryanstoner1
Copy link
Contributor Author

Thanks!

For reference, when you write patches, you don't need to merge the main branch into your development branch. github will automatically make sure nothing gets lost.

@bangerth Great, thank you for the pointer!

@bangerth bangerth merged commit eadfa70 into geodynamics:main Jul 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Further optimize the gravity postprocessor
2 participants