allow a different list of assemblers for each advection field #5233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to allow different advection fields to have different assemblers (i.e., we have different advection methods like advection field, diffusion field etc.) and not all of them require all assemblers. In cases where a signal is used to replace assemblers, it may even be necessary to only do that for specific fields and not for all of them.
This PR makes the advection system assembers a vector of vectors (with each compositional field having their individual vector of advection assemblers). At the moment, all fields still get the same assemblers, to test that this change does not break any functionality. The next step would be to only include the assemblers that are needed in each list (in a separate PR).
The change in the entropy benchmark shows how this could look like.
I also want to see which tests this breaks to see where I still have to fix the assemblers.
For all pull requests: