Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cookbook/benchmark warnings #5235

Merged
merged 1 commit into from Jul 9, 2023
Merged

fix cookbook/benchmark warnings #5235

merged 1 commit into from Jul 9, 2023

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented Jul 9, 2023

No description provided.

gassmoeller
gassmoeller approved these changes Jul 9, 2023
View reviewed changes
Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, feel free to merge when the testers are done. I am surprised this doesnt show up in the tester, where we compile with -D CMAKE_CXX_FLAGS='-Werror' -D ASPECT_INSTALL_EXAMPLES=ON.

@bobmyhill bobmyhill merged commit 6da77fd into geodynamics:main Jul 9, 2023
6 checks passed
@tjhei tjhei deleted the example-warnings branch July 10, 2023 16:05
@tjhei tjhei mentioned this pull request Jul 10, 2023
Merged
MFraters added a commit that referenced this pull request Jul 10, 2023
@MFraters
Merge pull request #5249 from tjhei/2.5-cookbook-warnings
ac01e1f 
[2.5] take over #5235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bangerth bangerth bangerth approved these changes

@gassmoeller gassmoeller gassmoeller approved these changes

Assignees
No one assigned
Labels
ready to merge ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tjhei @bangerth @gassmoeller @bobmyhill