Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poison values not computed. #5247

Merged
merged 1 commit into from Jul 10, 2023
Merged

Poison values not computed. #5247

merged 1 commit into from Jul 10, 2023

Conversation

bangerth
Copy link
Contributor

In reference to the discussion in #5239. I'm curious to see what happens with this patch.

@naliboff @bobmyhill @MFraters FYI.

@bangerth bangerth mentioned this pull request Jul 10, 2023
Merged
MFraters
MFraters approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests pass, that is reassuring. Looks good to me, but would be good for someone else who is more familiar with this part of the code to also take a look at it.

@bobmyhill bobmyhill merged commit eb471b6 into geodynamics:main Jul 10, 2023
6 checks passed
@bangerth bangerth deleted the safety-first branch July 10, 2023 18:30
@gassmoeller gassmoeller mentioned this pull request Jul 10, 2023
Merged
@anne-glerum anne-glerum mentioned this pull request Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFraters MFraters MFraters approved these changes

Assignees
No one assigned
Labels
ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bangerth @MFraters @bobmyhill