fix for latest deal.II master: support cell_weight #5251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs to go into 2.5 |
bangerth
approved these changes
Jul 10, 2023
This was referenced Jul 10, 2023
tamiko
reviewed
Jul 10, 2023
| #if DEAL_II_VERSION_GTE(9,6,0) | ||
| unsigned int | ||
| cell_weight(const typename parallel::distributed::Triangulation<dim>::cell_iterator &cell, | ||
| const CellStatus status); |
There was a problem hiding this comment.
mhm This is less than ideal. I think we could meaningfully alleviate the issue by providing a deprecated using declaration within our Triangulation classes in deal.II. Would that help?
| case CellStatus::children_will_be_coarsened: | ||
| for (const auto &child : cell->child_iterators()) | ||
| n_particles_in_cell += particle_handler->n_particles_in_cell(child); | ||
| break; |
There was a problem hiding this comment.
Same here. I don't think it would hurt to make the names available again via using declarations or similar trickery.
|
It's still necessary to avoid deprecation warnings. |
gassmoeller
added a commit
that referenced
this pull request
Jul 10, 2023
[2.5] take over #5251: fix for latest deal.II master: support cell_weight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.