Do not leave NaN values in output vectors. #5253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also pushed a test and a changelog entry. |
jdannberg
reviewed
Jul 11, 2023
There was a problem hiding this comment.
Thank you for fixing this! Since the prm file is just a copy of the composition active cookbook with 5 lines changed, can you include that prm file rather than duplicating it?
Otherwise this looks good to me!
There is the same problem for the artificial viscosity composition postprocessor as well, but now that you found the solution, I can make a separate pull request for that.
|
I think this should work now as you suggest. |
tjhei
approved these changes
Jul 11, 2023
This was referenced Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 5238. @jdannberg FYI.