Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove todo to assert that viscosity has been requested and computed #5264

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Remove todo to assert that viscosity has been requested and computed #5264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions source/material_model/visco_plastic.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,8 +279,7 @@ namespace aspect

// Fill plastic outputs if they exist.
// The values in isostrain_viscosities only make sense when the calculate_isostrain_viscosities function
// has been called. TODO check here for in.requests_property(MaterialProperties::viscosity) or
// in fill_plastic_outputs as is done now?
// has been called.
// TODO do we even need a separate function? We could compute the PlasticAdditionalOutputs here like
// the ElasticAdditionalOutputs.
rheology->fill_plastic_outputs(i, volume_fractions, plastic_yielding, in, out, isostrain_viscosities);
Expand Down