Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test and plugin description and add test #5266

Merged
merged 6 commits into from Jul 13, 2023

Conversation

anne-glerum
Copy link
Contributor

@anne-glerum anne-glerum commented Jul 11, 2023

To finalize addressing issue #4056, I've cloned the test that checks whether surface and volume stress visualization output give the same results to include set Point-wise stress and strain = true. With this setting the stresses should actually be equal.

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

Copy link
Contributor

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you have verified that the two really do agree?

@anne-glerum
Copy link
Contributor Author

I assume you have verified that the two really do agree?

In the issue, I wrote that they are the same: "I've checked again now that #4181 is merged, and with point-wise values, the output on the surface mesh and the volume mesh is the same 🥳 ."

Do you want me to check again?

@bangerth
Copy link
Contributor

No, I was just wondering because here you wrote "With this setting the stresses should actually be equal." I take your word that they are :-)

@anne-glerum
Copy link
Contributor Author

While fixing the test, I also compared the output on the volume and on the surface mesh, and the stresses are indeed still the same.

@bangerth
Copy link
Contributor

You win the prize for the most thoroughly thought through PR then! :-)

@bangerth bangerth merged commit eeede27 into geodynamics:main Jul 13, 2023
6 checks passed
@anne-glerum anne-glerum deleted the update_test_description branch July 13, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants