New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the reference for Muparser. #5285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, nice!
/rebuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alarshi all these files are automatically generated from the corresponding .cc files (these are taken from the parameter descriptions in the declare_parameters
functions. Could you fix the references in the .cc files? Otherwise these changes will be overwritten the next time someone updates the parameters in the manual.
@gassmoeller Oh, good catch! I had seen that the changes were in generated files and thought "not necessary, but also no harm", but had totally missed that the origin was left unchanged :-) |
|
Thanks @bangerth @gassmoeller for the review and explaining the changes! I modified the source files in the latest commit but left the documentation as is. |
This PR fixes the old references to muparser library in the documentation.
Before your first pull request: