Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the reference for Muparser. #5285

Merged
merged 2 commits into from Jul 13, 2023

Conversation

alarshi
Copy link
Contributor

@alarshi alarshi commented Jul 13, 2023

This PR fixes the old references to muparser library in the documentation.

Before your first pull request:

Copy link
Contributor

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, nice!

@gassmoeller
Copy link
Member

/rebuild

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alarshi all these files are automatically generated from the corresponding .cc files (these are taken from the parameter descriptions in the declare_parameters functions. Could you fix the references in the .cc files? Otherwise these changes will be overwritten the next time someone updates the parameters in the manual.

@bangerth
Copy link
Contributor

@gassmoeller Oh, good catch! I had seen that the changes were in generated files and thought "not necessary, but also no harm", but had totally missed that the origin was left unchanged :-)

@bangerth
Copy link
Contributor

> grep -r 'muparser-format' source/
source/heating_model/function.cc:                                  "muparser library, see Section~\\ref{sec:muparser-format}."
source/prescribed_stokes_solution/function.cc:                                               "muparser library, see Section~\\ref{sec:muparser-format}.")
source/initial_temperature/function.cc:                                              "muparser library, see Section~\\ref{sec:muparser-format}.")
source/initial_temperature/adiabatic.cc:                             "muparser library, see Section~\\ref{sec:muparser-format}.");
source/boundary_heat_flux/function.cc:                                             "muparser library, see Section~\\ref{sec:muparser-format}."
source/boundary_composition/function.cc:                                               "muparser library, see Section~\\ref{sec:muparser-format}.")
source/boundary_velocity/function.cc:                                            "muparser library, see Section~\\ref{sec:muparser-format}."
source/mesh_deformation/function.cc:                                           "muparser library, see Section~\\ref{sec:muparser-format}.")
source/particle/property/function.cc:                                        "muparser library, see Section~\\ref{sec:muparser-format}.")
source/particle/generator/probability_density_function.cc:                                         "Section~\\ref{sec:muparser-format}. The "
source/gravity_model/function.cc:                                  "muparser library, see Section~\\ref{sec:muparser-format}.")
source/initial_composition/function.cc:                                              "muparser library, see Section~\\ref{sec:muparser-format}.")
source/boundary_temperature/function.cc:                                               "muparser library, see Section~\\ref{sec:muparser-format}.")
source/mesh_refinement/minimum_refinement_function.cc:                                              "muparser library, see Section~\\ref{sec:muparser-format}.")
source/mesh_refinement/maximum_refinement_function.cc:                                              "muparser library, see Section~\\ref{sec:muparser-format}.")

@alarshi
Copy link
Contributor Author

alarshi commented Jul 13, 2023

Thanks @bangerth @gassmoeller for the review and explaining the changes! I modified the source files in the latest commit but left the documentation as is.

@gassmoeller gassmoeller merged commit 7796ade into geodynamics:main Jul 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants