New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Viscoplastic lookup table #5296
base: main
Are you sure you want to change the base?
[WIP] Viscoplastic lookup table #5296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to continue this tomorrow, but a few comments for now. I think the general idea is correct, but we can optimize things a bit and make it easier to understand.
include/aspect/material_model/equation_of_state/thermodynamic_table_lookup.h
Outdated
Show resolved
Hide resolved
3daf0b5
to
0f4f0c3
Compare
source/material_model/equation_of_state/thermodynamic_table_lookup.cc
Outdated
Show resolved
Hide resolved
0f4f0c3
to
63553cd
Compare
63553cd
to
93a6877
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments, in particular with requests for more documentation. I think I begin to understand what you are doing here, but it will require a few rounds of improvements to get it into a state that is understandable for a non-expert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryanstoner1 - a few additional comments on top the existing ones, but so far I think the structure you implemented makes sense. At this stage, more documentation in the highlighted places would be helpful to understand what is happening in some places. Thanks for this contribution, it is part of a big step forward in the class of simulations we can do with the visco_plastic model!
Co-authored-by: Rene Gassmoeller <rene.gassmoeller@mailbox.org>
…o be more intuitive
A modification to the visco_plastic material model to optionally set viscosities with lookup tables. These tables are used in place of temperature or pressure conditions by reading a column for dominant phases. What the dominant phase is is checked against a user-provided list of phases of interest.
Update: The goal is to be able to replace the existing analytical phase functions with phase functions read from a lookup table. At the moment this only affects the rheology and anything that is touched by the phase functions. A future PR will add density lookup capabilities as well.
At the moment this is a WIP because:
It breaks some visco_plastic_phases tests because some new code is not avoided in the original non-lookup setup.Open questions are:
Many thanks to @naliboff @jdannberg @danieldouglas92 for previous discussions! Any additional feedback from those in the community would be appreciated!
Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.
Describe what you did in this PR and why you did it.
Before your first pull request:
For all pull requests:
For new features/models or changes of existing features: