Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mars topography #5316

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

mars topography #5316

wants to merge 2 commits into from

Conversation

cedrict
Copy link
Contributor

@cedrict cedrict commented Jul 14, 2023

This is work in progress. I will revisit it in the Fall.

Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.

Describe what you did in this PR and why you did it.

Before your first pull request:

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

*This section was contributed by Cedric Thieulot and Bart Root.*

From the original MOLA data (<https://attic.gsfc.nasa.gov/mola/>), we have created a topography file
(present in the folder of this cookbook) with a 1 degree resolution in both longitude and latitude
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't actually in the directory. You probably want to add it there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry about that !

@bangerth
Copy link
Contributor

No need to apologize :-) Let us know when you think it's in a state where you want anyone to review it!

@cedrict
Copy link
Contributor Author

cedrict commented Jul 14, 2023

as of now (last day of hackathon 2023), I can't/won't develop this further. Shall we keep it open or can we merge it as is?

@bangerth
Copy link
Contributor

Let's keep it open. I'd rather have an open PR than half-finished stuff in the project :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants