Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cookbook/benchmark validation more robust #5319

Conversation

gassmoeller
Copy link
Member

#5259 is failing because the cookbook/benchmark validation is not very robust concerning different path layouts. Make the test more robust:

  • automatically build all plugins in all subdirectories of the given cookbook/benchmark
  • by default try to run all .prm files in all subdirectories (except for doc/)
  • remove all special rules that are no longer necessary

@tjhei: can you take a look?

@gassmoeller gassmoeller changed the title Make script more robust. Remove special rules. Make cookbook/benchmark validation more robust Jul 14, 2023
Copy link
Member

@tjhei tjhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with building all plugins, no harm here.

I am not sure your other changes will work: in CI we only validate and not run all examples. For running, many special cases are necessary (files use resume features, others don't converge, etc).


davies_et_al/: dummy
+@$(def); make_lib $@/case-2.3-plugin
@$(def); run_prm $@ case-2.1.prm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this works? I vaguely recall that the other prm files resume this file.

@gassmoeller
Copy link
Member Author

Hmm, I guess you are right, I didnt try running the benchmarks. Let me think about this, maybe I split the PR up into the part dealing with plugins and the part dealing with prms.

@gassmoeller
Copy link
Member Author

I think this will get too complicated to be worth the effort. Closing for now, we can revisit if necessary.

@gassmoeller gassmoeller closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants