refactored Peierls to use log(stress) in the log strain rate function #5325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
approved these changes
Jul 14, 2023
| @@ -187,11 +187,12 @@ namespace aspect | |||
| // Apply a strict cutoff if this option is chosen by user. A strain rate cutoff | |||
| // will be first computed and then compared to the input strain rate. A cutoff | |||
| // on stress will be triggered if the input strain rate is smaller. | |||
| double log_strain_rate = std::log(strain_rate); | |||
There was a problem hiding this comment.
Suggested change
| double log_strain_rate = std::log(strain_rate); | |
| const double log_strain_rate = std::log(strain_rate); |
bobmyhill
force-pushed
the
refactor_peierls
branch
3 times, most recently
from
fe5392a
to
eebc58a
Compare
bobmyhill
force-pushed
the
refactor_peierls
branch
from
eebc58a
to
ef295ec
Compare
|
/rebuild |
|
@bobmyhill Thanks for notifying me, I could see your point very clearly in the PR. |
|
This looks ready, seems like we just forgot to merge it after the hackathon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor refactoring of the new
compute_exact_log_strain_rate_and_derivative()function in Peierls creep to use the log stress. This has two benefits:FYI @lhy11009