Address a clang compiler problem. #5328
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On @danieldouglas92 's laptop, the Levi-Civita variable introduced by @MFraters yesterday in #5318 leads to a linker error: It complains that there are duplicate copies of the variable in every object file. That's a compiler error:
constexpr
impliesconst
, andconst
variables at namespace scope are automaticallystatic
, i.e. every.cc
file that#include
s the header file has its own copy with internal linkage. Apparently, clang does not know that rule.As verified by @danieldouglas92, the problem can be worked around by explicitly marking the variable as
static
.