Create additional inputs and outputs for DG faces neighbouring cells #5340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while working on #4370.
When assembling advection equations on cell faces that are not on the domain boundary, the material model and heating model are evaluated for the neighbouring cell without setting up the additional material model inputs and outputs. The modifications I made in #4370 to the shear heating plugin require ElasticOutputs, which were thus not created.
The tests that use DG for composition use either the simple, the SolKz or the Annulus material model, which do not have additional material outputs. So a test with DG and additional outputs would be good to add?
With this PR, all the additional material model input and output is set up.
For all pull requests:
For new features/models or changes of existing features: