Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create additional inputs and outputs for DG faces neighbouring cells #5340

Conversation

anne-glerum
Copy link
Contributor

Found while working on #4370.

When assembling advection equations on cell faces that are not on the domain boundary, the material model and heating model are evaluated for the neighbouring cell without setting up the additional material model inputs and outputs. The modifications I made in #4370 to the shear heating plugin require ElasticOutputs, which were thus not created.

The tests that use DG for composition use either the simple, the SolKz or the Annulus material model, which do not have additional material outputs. So a test with DG and additional outputs would be good to add?

With this PR, all the additional material model input and output is set up.

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

Copy link
Contributor

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but as you say it would be nice to have a test with a material model that has these additional objects. I suppose that's how you found the problem, by running into a failed assertion?

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand @anne-glerum is traveling for a while and I would prefer to fix the bug for now. I have opened issue #5350 to remind us to create a test.

@gassmoeller gassmoeller merged commit b2904ea into geodynamics:main Aug 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants